OSASINFRA-4209: Migrate to openshift-tests-extension (OTE)#260
Conversation
|
@mandre: This pull request references OSASINFRA-4209 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This likely will have to be 3 separated PRs so that we can test and merge without breaking CI. |
|
I've dropped the last 2 commits that I'll restore in separate PRs once the CI shows the new entry point works well. |
Add cmd/extension/main.go as a new OTE-based test extension binary alongside the existing openshift-tests entry point. This registers all openstack tests with the OTE framework, adds [OTP] annotations to all Describe blocks, and integrates the extension build into the Makefile and Containerfile. The OTE binary discovers 51 tests and does not pull in origin's monitor test framework, avoiding the duplicate test results seen with the old entry point.
|
Unrelated failure. The tests from this test suite all ran and were all successful. |
|
@mandre: Overrode contexts on behalf of mandre: ci/prow/test DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mandre: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified bypass |
|
@mandre: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve We won't know if this works until openshift/release#79487 merges, so let's kick on and see |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update the openstack-test main CI configuration to support the OTE migration in openshift/openstack-test#260. Changes: - binary_build_commands: build OTE extension binary via 'make tests-ext-build', package as tar.gz, and place at /usr/bin/ for payload discovery by openshift-tests - build test: verify the extension binary with --help instead of the removed openstack-tests binary - test/ccpmso jobs: use new openstack-test-openstack-ote step ref - dualstack jobs: override test phase with openshift-e2e-test + openstack-test-openstack-ote (replacing the old chain that used openstack-test-openstack) New step registry ref openstack-test-openstack-ote: - Runs from 'tests' image (openshift-tests) instead of 'openstack-tests' - Discovers the openstack-test extension from the release payload - Grants image-puller access for extension discovery - Supports same env vars: OS_CLOUD, OPENSTACK_TEST_SKIPS, CONFIG_TYPE - Runs 'openshift-tests run openstack-test/all' suite The old openstack-test-openstack step ref is preserved for older release branches that still use the standalone openstack-tests binary.
Update the openstack-test main CI configuration to support the OTE migration in openshift/openstack-test#260. Changes: - binary_build_commands: build OTE extension binary via 'make tests-ext-build', package as tar.gz, and place at /usr/bin/ for payload discovery by openshift-tests - build test: verify the extension binary with --help instead of the removed openstack-tests binary - test/ccpmso jobs: use new openstack-test-openstack-ote step ref - dualstack jobs: override test phase with openshift-e2e-test + openstack-test-openstack-ote (replacing the old chain that used openstack-test-openstack) New step registry ref openstack-test-openstack-ote: - Runs from 'tests' image (openshift-tests) instead of 'openstack-tests' - Discovers the openstack-test extension from the release payload - Grants image-puller access for extension discovery - Supports same env vars: OS_CLOUD, OPENSTACK_TEST_SKIPS, CONFIG_TYPE - Runs 'openshift-tests run openstack-test/all' suite The old openstack-test-openstack step ref is preserved for older release branches that still use the standalone openstack-tests binary.
Migrate to OTE using the
ote-migrationskill [1].Add cmd/extension/main.go as a new OTE-based test extension binary
alongside the existing openshift-tests entry point. This registers
all openstack tests with the OTE framework, adds [OTP] annotations
to all Describe blocks, and integrates the extension build into the
Makefile and Containerfile.
The OTE binary discovers 51 tests and does not pull in origin's
monitor test framework, avoiding the duplicate test results seen
with the old entry point.
[1] https://github.com/openshift-eng/ai-helpers/tree/main/plugins/ote-migration