Skip to content

OSASINFRA-4209: Migrate to openshift-tests-extension (OTE)#260

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:migrate-ote
May 21, 2026
Merged

OSASINFRA-4209: Migrate to openshift-tests-extension (OTE)#260
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:migrate-ote

Conversation

@mandre
Copy link
Copy Markdown
Member

@mandre mandre commented May 19, 2026

Migrate to OTE using the ote-migration skill [1].

Add cmd/extension/main.go as a new OTE-based test extension binary
alongside the existing openshift-tests entry point. This registers
all openstack tests with the OTE framework, adds [OTP] annotations
to all Describe blocks, and integrates the extension build into the
Makefile and Containerfile.

The OTE binary discovers 51 tests and does not pull in origin's
monitor test framework, avoiding the duplicate test results seen
with the old entry point.

[1] https://github.com/openshift-eng/ai-helpers/tree/main/plugins/ote-migration

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 19, 2026

@mandre: This pull request references OSASINFRA-4209 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Migrate to OTE using the ote-migration skill [1].

[1] https://github.com/openshift-eng/ai-helpers/tree/main/plugins/ote-migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mandre
Copy link
Copy Markdown
Member Author

mandre commented May 20, 2026

This likely will have to be 3 separated PRs so that we can test and merge without breaking CI.

@mandre
Copy link
Copy Markdown
Member Author

mandre commented May 20, 2026

I've dropped the last 2 commits that I'll restore in separate PRs once the CI shows the new entry point works well.

Add cmd/extension/main.go as a new OTE-based test extension binary
alongside the existing openshift-tests entry point. This registers
all openstack tests with the OTE framework, adds [OTP] annotations
to all Describe blocks, and integrates the extension build into the
Makefile and Containerfile.

The OTE binary discovers 51 tests and does not pull in origin's
monitor test framework, avoiding the duplicate test results seen
with the old entry point.
@mandre
Copy link
Copy Markdown
Member Author

mandre commented May 21, 2026

Unrelated failure. The tests from this test suite all ran and were all successful.
/override ci/prow/test

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@mandre: Overrode contexts on behalf of mandre: ci/prow/test

Details

In response to this:

Unrelated failure. The tests from this test suite all ran and were all successful.
/override ci/prow/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mandre
Copy link
Copy Markdown
Member Author

mandre commented May 21, 2026

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@mandre: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Copy Markdown
Contributor

/approve
/lgtm

We won't know if this works until openshift/release#79487 merges, so let's kick on and see

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 20acc9c into openshift:main May 21, 2026
5 checks passed
@openshift-merge-bot openshift-merge-bot Bot deleted the migrate-ote branch May 21, 2026 12:24
mandre added a commit to shiftstack/release that referenced this pull request May 21, 2026
Update the openstack-test main CI configuration to support the OTE
migration in openshift/openstack-test#260.

Changes:
- binary_build_commands: build OTE extension binary via 'make
  tests-ext-build', package as tar.gz, and place at /usr/bin/ for
  payload discovery by openshift-tests
- build test: verify the extension binary with --help instead of the
  removed openstack-tests binary
- test/ccpmso jobs: use new openstack-test-openstack-ote step ref
- dualstack jobs: override test phase with openshift-e2e-test +
  openstack-test-openstack-ote (replacing the old chain that used
  openstack-test-openstack)

New step registry ref openstack-test-openstack-ote:
- Runs from 'tests' image (openshift-tests) instead of 'openstack-tests'
- Discovers the openstack-test extension from the release payload
- Grants image-puller access for extension discovery
- Supports same env vars: OS_CLOUD, OPENSTACK_TEST_SKIPS, CONFIG_TYPE
- Runs 'openshift-tests run openstack-test/all' suite

The old openstack-test-openstack step ref is preserved for older release
branches that still use the standalone openstack-tests binary.
mandre added a commit to shiftstack/release that referenced this pull request May 21, 2026
Update the openstack-test main CI configuration to support the OTE
migration in openshift/openstack-test#260.

Changes:
- binary_build_commands: build OTE extension binary via 'make
  tests-ext-build', package as tar.gz, and place at /usr/bin/ for
  payload discovery by openshift-tests
- build test: verify the extension binary with --help instead of the
  removed openstack-tests binary
- test/ccpmso jobs: use new openstack-test-openstack-ote step ref
- dualstack jobs: override test phase with openshift-e2e-test +
  openstack-test-openstack-ote (replacing the old chain that used
  openstack-test-openstack)

New step registry ref openstack-test-openstack-ote:
- Runs from 'tests' image (openshift-tests) instead of 'openstack-tests'
- Discovers the openstack-test extension from the release payload
- Grants image-puller access for extension discovery
- Supports same env vars: OS_CLOUD, OPENSTACK_TEST_SKIPS, CONFIG_TYPE
- Runs 'openshift-tests run openstack-test/all' suite

The old openstack-test-openstack step ref is preserved for older release
branches that still use the standalone openstack-tests binary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants